Skip to content

Updates impeller page to mention desktop compatibility. - #13635

Merged
parlough merged 7 commits into
flutter:mainfrom
gaaclarke:desktop-impeller
Aug 12, 2026
Merged

parlough merged 7 commits into
flutter:mainfrom
gaaclarke:desktop-impeller

Conversation

@gaaclarke

@gaaclarke gaaclarke commented Jul 28, 2026 •

Copy link
Copy Markdown
Member

Description of what this PR is changing or adding, and why:

This updates the impeller guidance to cover desktop compatibility.

Issues fixed by this PR (if any):

fixes flutter/flutter#190159

PRs or commits this PR depends on (if any):

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@gaaclarke
gaaclarke requested a review from loic-sharma July 28, 2026 20:46
@flutter-website-bot

flutter-website-bot commented Jul 28, 2026 •

Copy link
Copy Markdown
Collaborator

Staged preview of the updated docs.flutter.dev site (updated for commit c963a81):

https://flutter-docs-prod--docs-pr13635-desktop-impeller-2hcqvapx.web.app

@flutter-website-bot

flutter-website-bot commented Jul 28, 2026 •

Copy link
Copy Markdown
Collaborator

Staged preview of the updated flutter.dev site (updated for commit c963a81):

https://flutter-dev-230821--www-pr13635-desktop-impeller-e7l6jsvm.web.app

@loic-sharma loic-sharma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@parlough parlough left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates @gaaclarke! Generally looks good to me, but can you add some additional context to the opt out instructions?

Comment thread sites/docs/src/content/perf/impeller.md Resolved
Comment thread sites/docs/src/content/perf/impeller.md Resolved
Comment thread sites/docs/src/content/perf/impeller.md Resolved
Comment thread sites/docs/src/content/perf/impeller.md Resolved
Comment thread sites/docs/src/content/perf/impeller.md Resolved
Comment thread sites/docs/src/content/perf/impeller.md Resolved
gaaclarke and others added 2 commits August 6, 2026 10:33
Co-authored-by: Parker Lougheed <parlough@gmail.com>
@gaaclarke
gaaclarke requested a review from parlough August 6, 2026 17:39
@gaaclarke

Copy link
Copy Markdown
Member Author

Sorry, I missed this. All of my filters for what requires my attention ignore drafts.

@parlough parlough left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those adjustments!

@parlough
parlough marked this pull request as ready for review August 12, 2026 19:35
@parlough
parlough requested review from a team and sfshaza2 as code owners August 12, 2026 19:35

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Impeller documentation to reflect that it is enabled by default as of Flutter 3.47 on macOS, Linux, and Windows, and provides instructions on how to disable it. The review feedback suggests wrapping lines that exceed the 80-character limit for semantic line breaks and using forward slashes instead of backslashes for the Windows path to maintain consistency and avoid markdown escaping issues.

Comment thread sites/docs/src/content/perf/impeller.md Resolved
Comment thread sites/docs/src/content/perf/impeller.md Resolved
@parlough
parlough merged commit 98cd229 into flutter:main Aug 12, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update impeller page for desktop information

4 participants