Repository navigation
Updates impeller page to mention desktop compatibility. - #13635
Conversation
|
Staged preview of the updated docs.flutter.dev site (updated for commit c963a81): https://flutter-docs-prod--docs-pr13635-desktop-impeller-2hcqvapx.web.app |
|
Staged preview of the updated flutter.dev site (updated for commit c963a81): https://flutter-dev-230821--www-pr13635-desktop-impeller-e7l6jsvm.web.app |
parlough
left a comment
There was a problem hiding this comment.
Thanks for these updates @gaaclarke! Generally looks good to me, but can you add some additional context to the opt out instructions?
Co-authored-by: Parker Lougheed <parlough@gmail.com>
|
Sorry, I missed this. All of my filters for what requires my attention ignore drafts. |
parlough
left a comment
There was a problem hiding this comment.
Thanks for those adjustments!
There was a problem hiding this comment.
Code Review
This pull request updates the Impeller documentation to reflect that it is enabled by default as of Flutter 3.47 on macOS, Linux, and Windows, and provides instructions on how to disable it. The review feedback suggests wrapping lines that exceed the 80-character limit for semantic line breaks and using forward slashes instead of backslashes for the Windows path to maintain consistency and avoid markdown escaping issues.
Description of what this PR is changing or adding, and why:
This updates the impeller guidance to cover desktop compatibility.
Issues fixed by this PR (if any):
fixes flutter/flutter#190159
PRs or commits this PR depends on (if any):
Presubmit checklist
of 80 characters or fewer.